Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external: range job keys and region split keys are 2 concepts (part 1) (#55659) #55781

Closed
wants to merge 3 commits into from
Closed

external: range job keys and region split keys are 2 concepts (part 1) (#55659) #55781

wants to merge 3 commits into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55659

What problem does this PR solve?

Issue Number: ref #55374

Problem Summary:

What changed and how does it work?

This is the first part of making job range keys and region split keys 2 different concetps, and it's only related to external engine changing. In next PR I'll change how lighting local backend will use them.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 30, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.3 labels Aug 30, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.3@1a0c3ac). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.3     #55781   +/-   ##
================================================
  Coverage               ?   56.1041%           
================================================
  Files                  ?       1700           
  Lines                  ?     612867           
  Branches               ?          0           
================================================
  Hits                   ?     343844           
  Misses                 ?     245531           
  Partials               ?      23492
Flag Coverage Δ
integration 37.2140% <71.8750%> (?)
unit 71.8445% <61.4583%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5744% <0.0000%> (?)

@lance6716 lance6716 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lance6716 lance6716

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @lance6716